Re: [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4

From: Andi Shyti
Date: Tue Jul 16 2024 - 14:27:29 EST


Hi Thomas,

On Tue, Jul 09, 2024 at 07:35:34PM GMT, Thomas Weißschuh wrote:
> Patches 1 is a preparation patch.
> Patch 2 is the actual change to piix4.
>
> Patch 1 drops the warning about muxed busses.
> I didn't feel that the warning only would warrant the additional
> complexity it introduces with multiple callers of i2c_register_spd().
>
> If others feel different, maybe a more generic warning/info or a source
> code comment would suffice.
>
> On a machine with 32 slots of which 16 are populated only the first 8
> slots are addressable, half of which are empty.
> Unfortunately I couldn't run a custom kernel for testing.
> But manually instantiating ee1004 devices worked as expected,
> so the proposed changes should also work.
>
> Tested with spd5118 and two DIMMs.
>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

with the comment added, pushed to

i2c/i2c-host.

Thanks,
Andi