Re: [GIT PULL 2/4] soc: dt updates for 6.11

From: Linus Torvalds
Date: Tue Jul 16 2024 - 14:56:13 EST


On Mon, 15 Jul 2024 at 14:03, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/soc-dt-6.11

WTF, Arnd?

This doesn't even *build*:

> Jagadeesh Kona (8):
> clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver

because it has

ret = qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8650_desc, regmap);

which is entirely wrong.

And no, this is not some kind of merge mistake of mine. It was wrong
in your tree.

qcom_cc_really_probe() has always taken a

struct platform_device *pdev

as the first argument, not a "struct device *". So the "&pdev->dev"
thing is completely wrong, and always has been.

Looking around, this was also reported by the kernel test robot at

https://lore.kernel.org/all/202407072331.baglL4Sd-lkp@xxxxxxxxx/
https://lore.kernel.org/all/202407072212.WptVaUDt-lkp@xxxxxxxxx/

and still I had to just notice it in my local build test.

I did fix it up, but this is *not* ok.

Linus