Re: [PATCH] x86/resctrl: Use seq_putc() in two functions

[Christian Heusel]

On 24/07/16 02:43PM, Reinette Chatre wrote:
> Hi Markus,
> 
> On 7/13/24 2:00 AM, Markus Elfring wrote:
> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > Date: Sat, 13 Jul 2024 10:43:14 +0200
> > 
> > Single characters should be put into a sequence.
> > Thus use the corresponding function “seq_putc”.
> > 
> > This issue was transformed by using the Coccinelle software.
> 
> Could you please point me to how you accomplished this? I tried
> on the latest upstream as well as the latest resctrl staged
> changes in tip's x86/cache but the needed coccinelle scripts do
> not seem to be available. I tried by running the commands below. It appeared
> to run many coccinelle scripts but there was not one related to this change.
> Is this a new coccinelle script outside of the kernel or still
> on its way upstream?
> 
> make C=2 CHECK=scripts/coccicheck MODE=report arch/x86/kernel/cpu/resctrl/rdtgroup.o
> make C=2 CHECK=scripts/coccicheck MODE=report arch/x86/kernel/cpu/resctrl/ctrlmondata.o

Just to give some context to this: Markus usually uses extra
(out-of-tree) coccinelle scripts to change code to his liking, sometimes
these are good changes, sometimes they are meaningless.

See for example this:

https://lore.kernel.org/all/50978c86-cf4a-991d-54ab-50d8d977f946@xxxxxxxx/

Some well known kernel contributors also have auto-replies (although in
a different context) specially for this contributor:

https://lore.kernel.org/all/2024071537-schematic-envoy-4272@gregkh/

Cheers,
Chris

Attachment: signature.asc
Description: PGP signature