Re: [PATCH] x86/resctrl: Use seq_putc() in two functions

From: Christophe JAILLET
Date: Wed Jul 17 2024 - 01:12:33 EST


Le 16/07/2024 à 23:43, Reinette Chatre a écrit :
Hi Markus,

On 7/13/24 2:00 AM, Markus Elfring wrote:
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 13 Jul 2024 10:43:14 +0200

Single characters should be put into a sequence.
Thus use the corresponding function “seq_putc”.


...

Could you please highlight the benefit of this change? Looking at seq_puts() implementation, thanks
to [1], it seems to me these seq_puts() calls will result in seq_putc() anyway?

Hi,

in this case, there is no benefit and the generated code should be exactly the same.

CJ


Reinette

[1] https://lore.kernel.org/all/a8589bffe4830dafcb9111e22acf06603fea7132.1713781332.git.christophe.jaillet@xxxxxxxxxx/