Re: [PATCH 2/2] wifi: mwifiex: add support for WPA-PSK-SHA256

[Sascha Hauer]

Hi Francesco,

On Tue, Jul 16, 2024 at 09:57:31PM +0200, Francesco Dolcini wrote:
> Hello Sascha,
> 
> On Tue, Jul 16, 2024 at 01:33:28PM +0200, Sascha Hauer wrote:
> > This adds support for the WPA-PSK AKM suite with SHA256 as hashing
> > method (WPA-PSK-SHA256). Tested with a wpa_supplicant provided AP
> > using key_mgmt=WPA-PSK-SHA256.
> 
> Do you have any more details on which chip/firmware you tested?
> The change looks good, I am just wondering if there are reasons this
> might create issue on some specific chip/firmware combination.

I have a IW416 with firmware 16.92.21.p119. The change itself is derived
from the downstream driver. The downstream driver also sets the
KEY_MGMT_PSK_SHA256 bit unconditionally for all chip/firmware
combinations so I think this change should be ok.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |