Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit()

From: Michal Hocko
Date: Wed Jul 17 2024 - 03:25:59 EST


On Wed 17-07-24 14:59:40, Miaohe Lin wrote:
> On 2024/7/17 14:18, Michal Hocko wrote:
[...]
> > Why does this need to be done through different modules? Why it cannot
> > be part of the memory-filure.c?
>
> This is a bold idea for me. :) I think it can be part of the memory-filure.c.
> So CONFIG_HWPOISON_INJECT should be removed from the world and then make
> hwpoison-inject default on when MEMORY_FAILURE is configured?

I would start by moving code into mm/hwpoison-inject.c. Whether this
should also remove CONFIG_HWPOISON_INJECT is a different question. I
am not really sure a debugfs interface warrants a config option. Anyway
two things for two separate patches
--
Michal Hocko
SUSE Labs