Re: [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0

[Conor Dooley]

On Wed, Jul 17, 2024 at 01:41:23PM +0200, Alexandre Ghiti wrote:

> > > Link: https://github.com/ClangBuiltLinux/linux/issues/1886#issuecomment-1645979992 [1]
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202407041157.odTZAYZ6-lkp@xxxxxxxxx/
> > > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> > If Nathan wrote the patch, you need to set him as the author of the
> > patch :)
> 
> 
> I thought I did, how should I do that then?

$ shazam 20240717-synapse-decade-a0d41bd7afce@spud
Grabbing thread from lore.kernel.org/all/20240717-synapse-decade-a0d41bd7afce@spud/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 4 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0
    + Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
  ---
  ✓ Signed: DKIM/rivosinc-com.20230601.gappssmtp.com (From: alexghiti@xxxxxxxxxxxx)
---
Total patches: 1
---
Applying: riscv: Allow to build only with LLVM >= 17.0.0
$ git show
commit f64f8420ca518b5dde35224cfff7ccfd14e5b496 (HEAD)
Author: Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>
Date:   Wed Jul 17 13:17:16 2024 +0200

    riscv: Allow to build only with LLVM >= 17.0.0
    
    The following build failure happens when using LLVM < 17.0.0:
    
    kernel/sched/core.c:11873:7: error: cannot jump from this asm goto statement to one of its possible targets
    
    This is a known issue [1] so let's upgrade the minimal requirement for
    LLVM to the version 17.0.0, which is the first version to contain the
    fix.
    
    Link: https://github.com/ClangBuiltLinux/linux/issues/1886#issuecomment-1645979992 [1]
    Reported-by: kernel test robot <lkp@xxxxxxxxx>
    Closes: https://lore.kernel.org/oe-kbuild-all/202407041157.odTZAYZ6-lkp@xxxxxxxxx/
    Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
    Signed-off-by: Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>
    Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>


When you commited it, you needed to set --author. Just adding his
signoff is not sufficient.

Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature