Re: [PATCH] clk: davinci: da8xx-cfgchip: Initialize clk_init_data before use

From: Bastien Curutchet
Date: Wed Jul 17 2024 - 10:46:57 EST


Hi David,

On 7/17/24 16:22, David Lechner wrote:
On 7/17/24 9:12 AM, Bastien Curutchet wrote:
The flag attribute of the struct clk_init_data isn't initialized before
the devm_clk_hw_register() call. This can lead to unexpected behavior
during registration.

Initialize the entire clk_init_data to zero at declaration.


Probably should add a Fixes: tag.


Sorry I forgot about it, that would be :

Fixes: 58e1e2d2cd89 ("clk: davinci: cfgchip: Add TI DA8XX USB PHY clocks")


Do I need to send a new iteration with it ?

Signed-off-by: Bastien Curutchet <bastien.curutchet@xxxxxxxxxxx>
---

Reviewed-by: David Lechner <david@xxxxxxxxxxxxxx>



Best regards,
Bastien