Using isfa (instead of isforcealign) might be interpreted as something elseThe check should be used in one single place where we decided if
we need to to the alignment based adjustments. So IMHO just killing
it and open coding it there seems way easier. Yes, it is in a loop,
but compared to all the work done is is really cheap.
I can take a look too.We've been long wanting to split the whole align / convert unwritten /ok, I'll see if can come up with something
etc code into a helper outside the main bumapi flow. And when adding
new logic to it this might indeed be a good time.
to account for cases where the transaction doesn't have a block
reservation, which I think could have happen in truncate until
Zhang Yi fixed it for the 6.11 merge window.