Re: [PATCH v2 1/7] arm/virt: place power button pin number on a define

[Jonathan Cameron]

On Fri, 12 Jul 2024 15:15:08 +0200
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:

> Having magic numbers inside the code is not a good idea, as it
> is error-prone. So, instead, create a macro with the number
> definition.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>

Seems sensible to me.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>