Re: [PATCH] wifi: b43: Constify struct lpphy_tx_gain_table_entry

From: Michael Büsch
Date: Wed Jul 17 2024 - 14:29:13 EST


On Tue, 16 Jul 2024 22:21:13 +0200
Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> static void lpphy_rev0_1_write_gain_table(struct b43_wldev *dev, int offset,
> - struct lpphy_tx_gain_table_entry data)
> + const struct lpphy_tx_gain_table_entry data)
> {
> u32 tmp;
>
> @@ -2356,7 +2356,7 @@ static void lpphy_rev0_1_write_gain_table(struct b43_wldev *dev, int offset,
> }
>
> static void lpphy_rev2plus_write_gain_table(struct b43_wldev *dev, int offset,
> - struct lpphy_tx_gain_table_entry data)
> + const struct lpphy_tx_gain_table_entry data)
> {
> u32 tmp;
>
> @@ -2383,7 +2383,7 @@ static void lpphy_rev2plus_write_gain_table(struct b43_wldev *dev, int offset,
> }
>
> void lpphy_write_gain_table(struct b43_wldev *dev, int offset,
> - struct lpphy_tx_gain_table_entry data)
> + const struct lpphy_tx_gain_table_entry data)
> {
> if (dev->phy.rev >= 2)
> lpphy_rev2plus_write_gain_table(dev, offset, data);
> @@ -2392,7 +2392,7 @@ void lpphy_write_gain_table(struct b43_wldev *dev, int offset,
> }

These three changes look like they are not necessary.

--
Michael Büsch
https://bues.ch/

Attachment: pgpQvj2nz2yEa.pgp
Description: OpenPGP digital signature