Re: [PATCH] kbuild: fix rebuild of generic syscall headers

From: Arnd Bergmann
Date: Wed Jul 17 2024 - 14:52:04 EST


On Wed, Jul 17, 2024, at 18:24, Masahiro Yamada wrote:
> Commit fbb5c0606fa4 ("kbuild: add syscall table generation to
> scripts/Makefile.asm-headers") started to generate syscall headers
> for architectures using generic syscalls.
>
> However, these headers are always rebuilt using GNU Make 4.4.1 or newer.
>
> When using GNU Make 4.4 or older, these headers are not rebuilt when the
> command to generate them is changed, despite the use of the if_changed
> macro.
>
> scripts/Makefile.asm-headers now uses FORCE, but it is not marked as
> .PHONY. To handle the command line change correctly, .*.cmd files must
> be included.
>
> Fixes: fbb5c0606fa4 ("kbuild: add syscall table generation to
> scripts/Makefile.asm-headers")
> Reported-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Closes:
> https://lore.kernel.org/lkml/CAHk-=wibB7SvXnUftBgAt+4-3vEKRpvEgBeDEH=i=j2GvDitoA@xxxxxxxxxxxxxx/
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>

Thanks a lot for the fix!

Tested-by: Arnd Bergmann <arnd@xxxxxxxx>