Re: [PATCH] bcachefs: WARNING in bch2_fs_journal_stop

[AP]

On Wed, Jul 17, 2024 at 06:02:39PM -0400, Camila Alvarez wrote:
> diff --git a/fs/bcachefs/journal.c b/fs/bcachefs/journal.c
> index 10b19791ec98..7bbbf4b149e9 100644
> --- a/fs/bcachefs/journal.c
> +++ b/fs/bcachefs/journal.c
> @@ -1201,7 +1201,7 @@ int bch2_fs_journal_start(struct journal *j, u64 cur_seq)
>  	struct journal_replay *i, **_i;
>  	struct genradix_iter iter;
>  	bool had_entries = false;
> -	u64 last_seq = cur_seq, nr, seq;
> +        u64 last_written_seq = cur_seq - 1, last_seq = cur_seq - 1, nr, seq;

Spaces not tabs. I think consistency would be wanted so should be a tab.

AP