Re: [PATCH v2] sched/fair: Remove cfs_rq::nr_spread_over and cfs_rq::exec_clock

[K Prateek Nayak]

Hello Chuyi,

On 7/17/2024 8:03 PM, Chuyi Zhou wrote:
> nr_spread_over tracks the number of instances where the difference
> between a scheduling entity's virtual runtime and the minimum virtual
> runtime in the runqueue exceeds three times the scheduler latency,
> indicating significant disparity in task scheduling.
> Commit that removed its usage: 5e963f2bd: sched/fair: Commit to EEVDF

scripts/checkpatch.pl complains about the commit description style here.
The above can be reworded as:

Commit 5e963f2bd465 ("sched/fair: Commit to EEVDF") removed its usage.

> cfs_rq->exec_clock was used to account for time spent executing tasks.
> Commit that removed its usage: 5d69eca542ee1 sched: Unify runtime
> accounting across classes

And this as:

Commit 5d69eca542ee ("sched: Unify runtime accounting across classes")
removed its usage.

> cfs_rq::nr_spread_over and cfs_rq::exec_clock are not used anymore in
> eevdf. Remove them from struct cfs_rq.
>
> Signed-off-by: Chuyi Zhou <zhouchuyi@xxxxxxxxxxxxx>
> Acked-by: Vishal Chourasia <vishalc@xxxxxxxxxxxxx>
> Reviewed-by: Chengming Zhou <chengming.zhou@xxxxxxxxx>

Apart from those nits,

Reviewed-by: K Prateek Nayak <kprateek.nayak@xxxxxxx>

--
Thanks and Regards,
Prateek

> ---
>   kernel/sched/debug.c | 4 ----
>   kernel/sched/sched.h | 6 ------
>   2 files changed, 10 deletions(-)
>
> [..snip..]