Re: [PATCH v4 01/12] dt-bindings: PCI: Cleanup of brcmstb YAML and add 7712 SoC

From: Krzysztof Kozlowski
Date: Thu Jul 18 2024 - 02:03:11 EST


On 17/07/2024 23:06, Florian Fainelli wrote:
>>> + resets:
>>> + minItems: 1
>>> + items:
>>> + - description: reset for external PCIe PERST# signal # perst
>>> + - description: reset for phy reset calibration # rescal
>>> +
>>> + reset-names:
>>> + minItems: 1
>>> + items:
>>> + - const: perst
>>> + - const: rescal
>>
>> There are no devices with two resets. Anyway, this does not match one of
>> your variants which have first element as rescal.
>
> Just to be clear, is the diff below what you would expect to see when
> applying both patch 1 and 4 in succession, that is the reset properties
> are described "generically" and the conditional section only describes
> the order and values:

Yeah, this would work. I still propose the format I provided link to
(here in this thread or in my talks).

Best regards,
Krzysztof