Re: [PATCH v2 1/8] x86/PCI: Move some logic to new function

From: Stewart Hildebrand
Date: Thu Jul 18 2024 - 10:54:55 EST


On 7/17/24 15:28, Philipp Stanner wrote:
> On Tue, 2024-07-16 at 15:32 -0400, Stewart Hildebrand wrote:
>> ... to reduce indentation level. Take the opportunity to remove
>> redundant info from debug print string.
>
> Is that intended to be the final commit message or is it still a draft?
>
> I'd call the commit "x86/PCI: Improve code readability" (or sth like
> that) since that is what the commit is about. It's not so much about
> the code move per se.
>
> and have a short message such as:
>
> "
> The indentation in pcibios_allocate_dev_resources() is unusally deep.
>
> Improve that by moving some of its code to the new function
> alloc_resource().
>
> As we're at it, remove redundant information from dev_dbg().
> "
>
>
> Regards,
> P.

Thanks for the suggestion. I'll rework it.