Re: [PATCH v3 1/4] selftests: x86: check_initial_reg_state: remove manual counting and increase maintainability

From: Shuah Khan
Date: Thu Jul 18 2024 - 11:48:47 EST


On 7/18/24 05:32, Muhammad Usama Anjum wrote:
Removes manual counting of pass and fail tests. This increases readability
of tests, but also improves maintainability of the tests. Print logs in
standard format (without [RUN], [OK] tags)

Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
---
Changes since v1:
- correct description of the patch

Changes since v2:
- Update description of the patch and add before/after output

Before:
# selftests: x86: check_initial_reg_state_32
# [OK] All GPRs except SP are 0
# [OK] FLAGS is 0x202
ok 5 selftests: x86: check_initial_reg_state_32

After:
# selftests: x86: check_initial_reg_state_32
# TAP version 13
# 1..2
# ok 1 All GPRs except SP are 0
# ok 2 FLAGS is 0x202
# # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0
ok 5 selftests: x86: check_initial_reg_state_32

What's the output you see if you were run this as:

make ksefltest TARGETS=x86

How is this different from the output from the above command?

Please provide the same information for your other patches in this
series

thanks,
-- Shuah