Re: [PATCH] i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked()

[Frank Li]

On Thu, Jul 18, 2024 at 01:30:22PM -0500, Dan Carpenter wrote:
> This code has a typo so it returns positive EIO instead of negative -EIO.  Fix
> it!
> 
> Fixes: a7809cb368b9 ("i3c: master: svc: Improve DAA STOP handle code logic")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> ---
>  drivers/i3c/master/svc-i3c-master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index e80c002991f7..0a68fd1b81d4 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -874,7 +874,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master,
>  				 * address this time.
>  				 */
>  				if (prov_id[dev_nb] == nacking_prov_id) {
> -					ret = EIO;
> +					ret = -EIO;
>  					break;
>  				}
>  
> -- 
> 2.43.0
>