Re: [PATCH v3] vmstat: Kernel stack usage histogram

[Pasha Tatashin]

On Thu, Jul 18, 2024 at 7:19 PM Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote:
>
> Hi Pasha,
>
> On Wed, Jul 17, 2024 at 12:50:00PM GMT, Pasha Tatashin wrote:
> > On Wed, Jun 12, 2024 at 2:50 PM Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote:
> > >
> [...]
> > > >
> > > > One more question: Is there any concern in making
> > > > CONFIG_DEBUG_STACK_USAGE not a debug feature i.e. enable in default
> > > > kernels instead of just debug kernels?
> >
> > We enabled it in Google ProdKernel. There is some overhead when
> > threads are exiting, because we are looking for the first non-zero
> > byte, but that is minimal. We haven't observed any performance impact
> > on our fleet.
> >
>
> So, you would support making CONFIG_DEBUG_STACK_USAGE enabled by
> default, right?

Right, I see nothing wrong with having this enabled by default.

Pasha