Re: [PATCH v2 1/3] blk-cgroup: check for pd_(alloc|free)_fn in blkcg_activate_policy()

[Yu Kuai]

Hi!

在 2024/07/19 13:29, Christoph Hellwig 写道:
> On Fri, Jul 19, 2024 at 10:34:29AM +0800, Yu Kuai wrote:
> > +	/*
> > +	 * Make sure cpd/pd_alloc_fn and cpd/pd_free_fn in pairs, and policy
> > +	 * without pd_alloc_fn/pd_free_fn can't be activated.
> > +	 */
> >   	if ((!pol->cpd_alloc_fn ^ !pol->cpd_free_fn) ||
> >   		(!pol->pd_alloc_fn ^ !pol->pd_free_fn))
> >   		goto err_unlock;
> > --
>
> I know this is existing code, but can you fix up the incorrect
> indentation while you touch this:

Yes, and thanks for the review.

Kuai

>   	if ((!pol->cpd_alloc_fn ^ !pol->cpd_free_fn) ||
>   	    (!pol->pd_alloc_fn ^ !pol->pd_free_fn))
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
> .