Re: [PATCH v4 1/4] MAINTAINERS: Add entry for Synopsys DesignWare HDMI RX Driver

From: Christopher Obbard
Date: Fri Jul 19 2024 - 08:48:12 EST


Hi Shreeya,

On Fri, 2024-07-19 at 18:10 +0530, Shreeya Patel wrote:
> Add an entry for Synopsys DesignWare HDMI Receiver Controller
> Driver.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx>
> ---
>
> Changes in v4 :-
>   - No change
>
> Changes in v3 :-
>   - No change
>
> Changes in v2 :-
>   - Add a patch for MAINTAINERS file changes
>
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1c87b471941c..0f0e1d58abff 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -22138,6 +22138,14 @@ F: drivers/net/pcs/pcs-xpcs.c
>  F: drivers/net/pcs/pcs-xpcs.h
>  F: include/linux/pcs/pcs-xpcs.h
>  
> +SYNOPSYS DESIGNWARE HDMI RX CONTROLLER DRIVER

Perhaps a more descriptive name could be "SYNOPSYS DESIGNWARE HDMI RECEIVER
DRIVER" to better match the IP name:
https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_20_csds_rx


> +M: Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx
Should this not be:
Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx>

You seem to be missing the final > at the end of the line ?


With the above fixed:
Reviewed-by: Christopher Obbard <chris.obbard@xxxxxxxxxxxxx>

> +L: linux-media@xxxxxxxxxxxxxxx
> +L: kernel@xxxxxxxxxxxxx
> +S: Maintained
> +F: Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> +F: drivers/media/platform/synopsys/hdmirx/*
> +
>  SYNOPSYS DESIGNWARE I2C DRIVER
>  M: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
>  R: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>