Re: [PATCH] HID: core: Fix parsing error for Thinkbook16 G6+ IMH

[Benjamin Tissoires]

Hi,

Thanks for your contribution but there are many things wrong with your
patch submission:
- you used html which should be rejected by the mailing list
- your mail client completely messed up the format and the patch is not
  applicable in its current state.
- your signed-off-by is not correct as it's missing your email.

Please make sure to use `git send-email` or `b4` for your future
submissions

Also, the patch in itself (or what I could guess on the email I
received) is wrong. You should not tamper with hid-core for that but
need a dedicated report descriptor fixup in the target driver.

However, the device seems to rely on hid-multitouch which I'd rather not
have report descriptor fixups in there.

Maybe the simplest solution is to rely on HID-BPF and submit a new
driver fix to https://gitlab.freedesktop.org/libevdev/udev-hid-bpf or if
you want to directly submit said fix to the kernel in the directory
drivers/hid/bpf/progs.

Cheers,
Benjamin


On Jul 19 2024, 艾超 wrote: