Re: [PATCH 3/3] greybus: gb-beagleplay: Add firmware upload API

From: Andrew Lunn
Date: Fri Jul 19 2024 - 15:16:22 EST


> > drivers/greybus/Kconfig | 1 +
> > drivers/greybus/gb-beagleplay.c | 625 +++++++++++++++++++++++++++++++++++++++-

> > +static u8 csum8(const u8 *data, size_t size, u8 base)
> > +{
> > + size_t i;
> > + u8 sum = base;
> follow reverse x-mas tree

Since this is not networking, even thought it was posted to the netdev
list, this comment might not be correct. I had a quick look at some
greybus code and reverse x-mas tree is not strictly used.

Please see what the Graybus Maintainers say.

Andrew