Re: [PATCH 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

From: Markus Elfring
Date: Fri Jul 19 2024 - 16:34:30 EST



> +++ b/drivers/accel/amdxdna/aie2_pci.c
> @@ -0,0 +1,182 @@

> +static int aie2_init(struct amdxdna_dev *xdna)
> +{

> + release_firmware(fw);
> + return 0;

I find the following statements more appropriate here
(so that a bit of redundant code can be avoided).

ret = 0;
goto release_fw;


> +release_fw:
> + release_firmware(fw);
> +
> + return ret;
> +}



Regards,
Markus