Re: [PATCH v7 3/4] dt-bindings: iio: adc: ad7192: Add clock provider

[Jonathan Cameron]

On Thu, 18 Jul 2024 16:14:17 +0100
Conor Dooley <conor@xxxxxxxxxx> wrote:

> On Thu, Jul 18, 2024 at 12:25:34AM +0300, Alisa-Dariana Roman wrote:
> > Internal clock of AD719X devices can be made available on MCLK2 pin. Add
> > clock provider to support this functionality when clock cells property
> > is present.
> > 
> > The clock source can be either provided externally or the internal clock
> > is used. Pair of clocks and clock-names property is mutally exclusive
> > with #clock-cells property.
> > 
> > Modify second example to showcase the mode where internal clock is used.
> > 
> > Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/iio/adc/adi,ad7192.yaml     | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> > index c3adc32684cf..edfa4378e838 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> > @@ -42,13 +42,19 @@ properties:
> >      description:
> >        Optionally, either a crystal can be attached externally between MCLK1 and
> >        MCLK2 pins, or an external CMOS-compatible clock can drive the MCLK2
> > -      pin. If absent, internal 4.92MHz clock is used.
> > +      pin. If absent, internal 4.92MHz clock is used, which can be made
> > +      available on MCLK2 pin.
> >  
> >    clock-names:
> >      enum:
> >        - xtal
> >        - mclk
> >  
> > +  "#clock-cells":
> > +    const: 0
> > +    description:
> > +      If present when internal clock is used, configured as clock provider.
> > +
> >    interrupts:
> >      maxItems: 1
> >  
> > @@ -169,6 +175,8 @@ allOf:
> >        required:
> >          - clocks
> >          - clock-names
> > +      properties:
> > +        "#clock-cells": false  
> 
> Properties before required, otherwise
Tweaked whilst applying.

Thanks,

Jonathan

> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 
> Cheers,
> Conor.
> 
> >  
> >  unevaluatedProperties: false
> >  
> > @@ -214,8 +222,7 @@ examples:
> >              spi-max-frequency = <1000000>;
> >              spi-cpol;
> >              spi-cpha;
> > -            clocks = <&ad7192_mclk>;
> > -            clock-names = "mclk";
> > +            #clock-cells = <0>;
> >              interrupts = <25 0x2>;
> >              interrupt-parent = <&gpio>;
> >              aincom-supply = <&aincom>;
> > -- 
> > 2.34.1
> >