Re: [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi input driver

From: Markus Elfring
Date: Sun Jul 21 2024 - 11:07:24 EST



> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -0,0 +1,2763 @@

> +static void hdmirx_writel(struct snps_hdmirx_dev *hdmirx_dev, int reg, u32 val)
> +{

> + spin_lock_irqsave(&hdmirx_dev->rst_lock, lock_flags);
> + writel(val, hdmirx_dev->regs + reg);
> + spin_unlock_irqrestore(&hdmirx_dev->rst_lock, lock_flags);
> +}


Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&hdmirx_dev->rst_lock);”?
https://elixir.bootlin.com/linux/v6.10/source/include/linux/spinlock.h#L574

Regards,
Markus