Re: [PATCH v3 2/2] selftests/bpf: integrate test_xdp_veth into test_progs
From: Alexis Lothoré
Date: Sun Jul 21 2024 - 15:25:39 EST
Hello Daniel,
On 7/19/24 17:14, Daniel Borkmann wrote:
> On 7/16/24 12:13 PM, Alexis Lothoré (eBPF Foundation) wrote:
[...]
>> + nstoken = open_netns(config[index].namespace);
>> + if (!ASSERT_OK_PTR(nstoken, "switch to remote veth namespace"))
>> + return -1;
>> + interface = if_nametoindex(config[index].remote_veth);
>> + if (!ASSERT_NEQ(interface, 0, "non zero interface index"))
>> + return -1;
>
> Missing `close_netns(nstoken);` in error path here, otherwise looks reasonable
> to me.
Ah yes, good catch, thanks. v4 incoming with the corresponding fix.
Thanks,
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com