Re: [PATCH v1] hid-playstation: DS4: Update rumble and lightbar together

From: Max Staudt
Date: Sun Jul 21 2024 - 23:41:05 EST


On second thought, maybe we can sidestep this discussion entirely by using a new Kconfig to have both states configurable.

Something like:

CONFIG_HID_PLAYSTATION_V6_6_ANDROID_TEST_COMPAT

Improvements such as my patch would be turned off when this flag is enabled, and the driver behaviour reverted to the v6.6 LTS behaviour. So Android kernels would enable it, and everyone else (especially desktop distributions) can leave it off.

Then, once the Android test suite is fixed, the Kconfig can be removed. Looking at the Android release cadence in recent years, and the timeline of DS4 support in hid-playstation and in the v6.6 LTS kernel, I presume this would be in 1-2 years.

This way, upstream can continue improving the driver, without triggering Android test failures.


How does this sound?

Max