Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

From: Michael Ellerman
Date: Mon Jul 22 2024 - 03:24:31 EST


"Dr. David Alan Gilbert" <linux@xxxxxxxxxxx> writes:
> * Sean Anderson (sean.anderson@xxxxxxxxx) wrote:
>> On 5/28/24 19:11, linux@xxxxxxxxxxx wrote:
>> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>> >
>> > 'cgr_comp' has been unused since
>> > commit 96f413f47677 ("soc/fsl/qbman: fix issue in
>> > qman_delete_cgr_safe()").
>> >
>> > Remove it.
>> >
>> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
>> > ---
>> > drivers/soc/fsl/qbman/qman.c | 5 -----
>> > 1 file changed, 5 deletions(-)
>> >
>> > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
>> > index 7e9074519ad2..4dc8aba33d9b 100644
>> > --- a/drivers/soc/fsl/qbman/qman.c
>> > +++ b/drivers/soc/fsl/qbman/qman.c
>> > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
>> > }
>> > EXPORT_SYMBOL(qman_delete_cgr);
>> >
>> > -struct cgr_comp {
>> > - struct qman_cgr *cgr;
>> > - struct completion completion;
>> > -};
>> > -
>> > static void qman_delete_cgr_smp_call(void *p)
>> > {
>> > qman_delete_cgr((struct qman_cgr *)p);
>>
>> Reviewed-by: Sean Anderson <sean.anderson@xxxxxxxxx>
>
> Hi Sean,
> Do you know who will pick this one up?
> I got a notification a while ago from a patchwork at
> linuxppc-dev marked 'Handled elsewhere' - but I'm not
> sure where.

drivers/soc/fsl was orphaned, but Christophe has recently volunteered to
look after it.

This patch looks trivial so I can just pick it up if you like Christophe?

cheers