Re: [PATCH v6 4/4] pwm: adp5585: Add Analog Devices ADP5585 support

[Uwe Kleine-König]

On Sun, Jul 21, 2024 at 07:00:49PM +0300, Laurent Pinchart wrote:
> From: Clark Wang <xiaoning.wang@xxxxxxx>
> 
> The ADP5585 is a 10/11 input/output port expander with a built in keypad
> matrix decoder, programmable logic, reset generator, and PWM generator.
> This driver supports the PWM function using the platform device
> registered by the core MFD driver.
> 
> The driver is derived from an initial implementation from NXP, available
> in commit 113113742208 ("MLK-25922-1 pwm: adp5585: add adp5585 PWM
> support") in their BSP kernel tree. It has been extensively rewritten.
> 
> Signed-off-by: Clark Wang <xiaoning.wang@xxxxxxx>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Co-developed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

As expected I'm happy with this patch now. If you respin, consider
adding a comment to .request() describing the effect of the register
access there. I guess it's about pinmux, so something like:

	/* Configure the XYZ pin as PWM output */

(with XYZ replaced by something sensible of course).

It's fine for me if this patch gets in via MFD as suggested in the cover
letter.

Acked-by: Uwe Kleine-König <ukleinek@xxxxxxxxxx>

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature