Re: [PATCH v1 2/6] perf auxtrace arm: Set the 'auxtrace' flag for AUX events

From: Adrian Hunter
Date: Mon Jul 22 2024 - 06:49:35 EST


On 21/07/24 23:21, Leo Yan wrote:
> Originally, the 'auxtrace' flag in the PMU event is used for AUX area
> sampling. It indicates a PMU event is for AUX tracing.
>
> Set this flag for AUX trace events on Arm.
>
> Signed-off-by: Leo Yan <leo.yan@xxxxxxx>

Note same as:

https://lore.kernel.org/all/20240715160712.127117-6-adrian.hunter@xxxxxxxxx/

Either should be fine:

Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

> ---
> tools/perf/arch/arm/util/pmu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/arch/arm/util/pmu.c b/tools/perf/arch/arm/util/pmu.c
> index 1c9541d01722..b7fa1245e242 100644
> --- a/tools/perf/arch/arm/util/pmu.c
> +++ b/tools/perf/arch/arm/util/pmu.c
> @@ -25,6 +25,7 @@ void perf_pmu__arch_init(struct perf_pmu *pmu)
> /* add ETM default config here */
> pmu->selectable = true;
> pmu->perf_event_attr_init_default = cs_etm_get_default_config;
> + pmu->auxtrace = true;
> #if defined(__aarch64__)
> } else if (strstarts(pmu->name, ARM_SPE_PMU_NAME)) {
> pmu->selectable = true;
> @@ -32,8 +33,10 @@ void perf_pmu__arch_init(struct perf_pmu *pmu)
> pmu->perf_event_attr_init_default = arm_spe_pmu_default_config;
> if (strstarts(pmu->name, "arm_spe_"))
> pmu->mem_events = perf_mem_events_arm;
> + pmu->auxtrace = true;
> } else if (strstarts(pmu->name, HISI_PTT_PMU_NAME)) {
> pmu->selectable = true;
> + pmu->auxtrace = true;
> #endif
> }
> #endif