Re: [PATCH 1/3] dt-bindings: net: ti,cc1352p7: Add boot-gpio

[Conor Dooley]

On Mon, Jul 22, 2024 at 04:15:41PM +0530, Ayush Singh wrote:
> 
> On 7/19/24 20:25, Conor Dooley wrote:
> > On Fri, Jul 19, 2024 at 03:15:10PM +0530, Ayush Singh wrote:
> > > boot-gpio (along with reset-gpio) is used to enable bootloader backdoor
> > > for flashing new firmware.
> > > 
> > > The pin and pin level to enabel bootloader backdoor is configed using
> > > the following CCFG variables in cc1352p7:
> > > - SET_CCFG_BL_CONFIG_BL_PIN_NO
> > > - SET_CCFG_BL_CONFIG_BL_LEVEL
> > > 
> > > Signed-off-by: Ayush Singh <ayush@xxxxxxxxxxxxxxx>
> > > ---
> > >   Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > index 3dde10de4630..a3511bb59b05 100644
> > > --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > @@ -29,6 +29,9 @@ properties:
> > >     reset-gpios:
> > >       maxItems: 1
> > > +  boot-gpios:
> > > +    maxItems: 1
> > I think this needs a description that explains what this is actually
> > for, and "boot-gpios" is not really an accurate name for what it is used
> > for IMO.
> 
> I was using the name `boot-gpios` since cc1352-flasher uses the name
> boot-line. Anyway, would `bsl-gpios` be better?

I dunno, I think that "bsl" is worse.

> Or for more descriptive
> names, I guess it can be `bootloader-config-gpios` or

> `bootloader-backdoor-gpios`.

This is the most descriptive and therefore, IMO, best.

Attachment: signature.asc
Description: PGP signature