Re: [PATCH v1 3/6] perf auxtrace s390: Set the 'auxtrace' flag for AUX events

[Leo Yan]

On 7/22/24 11:54, Adrian Hunter wrote:

[...]

> On 21/07/24 23:21, Leo Yan wrote:
> > Set the 'auxtrace' flag for AUX events on s390.
> >
> > Signed-off-by: Leo Yan <leo.yan@xxxxxxx>
> > ---
> >   tools/perf/arch/s390/util/auxtrace.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/arch/s390/util/auxtrace.c b/tools/perf/arch/s390/util/auxtrace.c
> > index 5068baa3e092..d7e72413b262 100644
> > --- a/tools/perf/arch/s390/util/auxtrace.c
> > +++ b/tools/perf/arch/s390/util/auxtrace.c
> > @@ -99,6 +99,7 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist,
> >                if (pos->core.attr.config == PERF_EVENT_CPUM_SF_DIAG) {
> >                        diagnose = 1;
> >                        pos->needs_auxtrace_mmap = true;
> > +                     pos->pmu->auxtrace = true;
>
> This is probably too late. See:
>
> https://lore.kernel.org/all/20240715160712.127117-7-adrian.hunter@xxxxxxxxx/

Okay, I will drop this patch.

Thanks,
Leo


> >                        break;
> >                }
> >        }