Re: [PATCH v3] spi: ppc4xx: handle irq_of_parse_and_map() errors

From: Markus Elfring
Date: Mon Jul 22 2024 - 11:43:31 EST



> Signed-off-by: Ma Ke <make24@xxxxxxxxxxx>

Will any contributors care more for rules also according to such information?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n398
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/researcher-guidelines.rst?h=v6.10#n5



> +++ b/drivers/spi/spi-ppc4xx.c
> @@ -416,6 +416,9 @@ static int spi_ppc4xx_of_probe(struct platform_device *op)
> if (hw->irqnum <= 0)
> goto free_host;
>
> + if (hw->irqnum <= 0)
> + goto free_host;


Why do you propose anyhow to add duplicate source code here?

Regards,
Markus