Re: [PATCH] media: raspberrypi: VIDEO_RASPBERRYPI_PISP_BE should depend on ARCH_BCM2835

[Jacopo Mondi]

Hi Geert

On Mon, Jul 22, 2024 at 05:28:28PM GMT, Geert Uytterhoeven wrote:
> Currently, the Raspberry Pi PiSP Backend (BE) ISP is only present on the
> Broadcom BCM2712-based Raspberry Pi 5.  Hence add a dependency on
                                        ^ nit: double space

> ARCH_BCM2835, to prevent asking the user about this driver when
> configuring a kernel without Broadcom BCM2835 family support.  The

double space before "The" as well

> dependency can be relaxed if/when the encoder appears on other SoC
> families.

we can surely lift this requirement in the unlikely event this happens

Thanks
Acked-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>

>
> Fixes: 12187bd5d4f8c128 ("media: raspberrypi: Add support for PiSP BE")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>  drivers/media/platform/raspberrypi/pisp_be/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/raspberrypi/pisp_be/Kconfig b/drivers/media/platform/raspberrypi/pisp_be/Kconfig
> index 38c0f8305d620d83..46765a2e4c4d1573 100644
> --- a/drivers/media/platform/raspberrypi/pisp_be/Kconfig
> +++ b/drivers/media/platform/raspberrypi/pisp_be/Kconfig
> @@ -2,6 +2,7 @@ config VIDEO_RASPBERRYPI_PISP_BE
>  	tristate "Raspberry Pi PiSP Backend (BE) ISP driver"
>  	depends on V4L_PLATFORM_DRIVERS
>  	depends on VIDEO_DEV
> +	depends on ARCH_BCM2835 || COMPILE_TEST
>  	select VIDEO_V4L2_SUBDEV_API
>  	select MEDIA_CONTROLLER
>  	select VIDEOBUF2_DMA_CONTIG
> --
> 2.34.1
>