Re: [PATCH v2 1/2] dt-bindings: iio: adf4377: add adf4378 support

[Conor Dooley]

On Mon, Jul 22, 2024 at 04:45:05PM +0300, Antoniu Miclaus wrote:
> Add porperty conditions for the adf4378.
> Add product link for the adf4378.

I can see this from the diff. You need to explain /why/ this gpio is not
valid for use on this device.

> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> ---
> changes in v2:
>  - use property conditions for clk2 gpio
> Note: the compatible is already available from the firs iteration of the driver
> where these particularities weren't available for adf4378
>  .../devicetree/bindings/iio/frequency/adi,adf4377.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> index aa6a3193b4e0..5f950ee9aec7 100644
> --- a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> +++ b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> @@ -17,6 +17,7 @@ description: |
>     applications.
>  
>     https://www.analog.com/en/products/adf4377.html
> +   https://www.analog.com/en/products/adf4378.html
>  
>  properties:
>    compatible:
> @@ -73,6 +74,15 @@ required:
>  
>  allOf:
>    - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,adf4378
> +    then:
> +      properties:
> +        clk2-enable-gpios: false
>  
>  unevaluatedProperties: false
>  
> -- 
> 2.45.2
>

Attachment: signature.asc
Description: PGP signature