Re: [PATCH v7 2/4] dt-bindings: riscv: Add Svade and Svadu Entries

From: Conor Dooley
Date: Mon Jul 22 2024 - 12:51:55 EST


On Mon, Jul 22, 2024 at 10:14:11AM +0800, Yong-Xuan Wang wrote:

> > > > > + - const: svadu
> > > > > + description: |
> > > > > + The standard Svadu supervisor-level extension for hardware updating
> > > > > + of PTE A/D bits as ratified at commit c1abccf ("Merge pull request
> > > > > + #25 from ved-rivos/ratified") of riscv-svadu. Please refer to Svade
> > > >
> > > > Should we be referencing the archived riscv-svadu repository now that Svadu has
> > > > been merged to the main privileged ISA manual? Either way:
> > > >
> > > > Reviewed-by: Samuel Holland <samuel.holland@xxxxxxxxxx>
> > > >
> > >
> > > Yes, this commit is from the archived riscv-svadu repo. Or should I update it to
> > > "commit c1abccf ("Merge pull request #25 from ved-rivos/ratified") of
> > > riscvarchive/riscv-svadu."?
> >
> > I think Samuel was saying that we should use the commit where it was
> > merged into riscv-isa-manual instead.
>
> Got it. I will update the description in the next version. Thank you!

There's no need (IMO) to send a new version for this alone - but if you
have to send another version for some other reason then do it.

Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature