Re: [PATCH] scsi: ufs: core: Do not set link to OFF state while waking up from hibernation

From: Bart Van Assche
Date: Mon Jul 22 2024 - 13:57:54 EST


On 7/18/24 10:06 AM, Manivannan Sadhasivam wrote:
UFS link is just put into hibern8 state during the 'freeze' process of the
hibernation. Afterwards, the system may get powered down. But that doesn't
matter during wakeup. Because during wakeup from hibernation, UFS link is
again put into hibern8 state by the restore kernel and then the control is
handed over to the to image kernel.

So in both the places, UFS link is never turned OFF. But
ufshcd_system_restore() just assumes that the link will be in OFF state and
sets the link state accordingly. And this breaks hibernation wakeup:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>