Re: [PATCH v10 10/10] xfs: enable block size larger than page size support

[Darrick J. Wong]

On Mon, Jul 22, 2024 at 02:12:20PM +0000, Pankaj Raghav (Samsung) wrote:
> > > +
> > > +		if (mp->m_sb.sb_blocksize > max_folio_size) {
> > > +			xfs_warn(mp,
> > > +"block size (%u bytes) not supported; maximum folio size supported in "\
> > > +"the page cache is (%ld bytes). Check MAX_PAGECACHE_ORDER (%d)",
> > > +			mp->m_sb.sb_blocksize, max_folio_size,
> > > +			MAX_PAGECACHE_ORDER);
> > > +			error = -ENOSYS;
> > > +			goto out_free_sb;
> > 
> > Nit: Continuation lines should be indented, not lined up with the next
> > statement:
> > 
> > 			xfs_warn(mp,
> > "block size (%u bytes) not supported; maximum folio size supported in "\
> > "the page cache is (%ld bytes). Check MAX_PAGECACHE_ORDER (%d)",
> > 					mp->m_sb.sb_blocksize,
> > 					max_folio_size,
> > 					MAX_PAGECACHE_ORDER);
> > 			error = -ENOSYS;
> > 			goto out_free_sb;
> 
> @Darrick: As willy pointed out, the error message is a bit long here.
> Can we make as follows:
> 
> "block size (%u bytes) not supported; Only block size (%ld) or less is supported "\
>                                         mp->m_sb.sb_blocksize,
>                                         max_folio_size);
> 
> This is similar to the previous error and it is more concise IMO.

Ah, ok.  I suppose printing max_folio_size *and* MAX_PAGECACHE_ORDER is
redundant.  The shortened version above is ok by me.

--D

> > 
> > With that fixed,
> > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > 
> > --D
> > 
>