Re: [PATCH 3/7] drm/i915/pmu: Use event_to_pmu()

[Dixit, Ashutosh]

On Mon, 22 Jul 2024 14:06:44 -0700, Lucas De Marchi wrote:
>
> i915 pointer is not needed in this function and all the others simply
> calculate the i915_pmu container based on the event->pmu. Follow the
> same logic as in other functions.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>

>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_pmu.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
> index cb5f6471ec6e..3a8bd11b87e7 100644
> --- a/drivers/gpu/drm/i915/i915_pmu.c
> +++ b/drivers/gpu/drm/i915/i915_pmu.c
> @@ -820,15 +820,14 @@ static void i915_pmu_event_start(struct perf_event *event, int flags)
>
>  static void i915_pmu_event_stop(struct perf_event *event, int flags)
>  {
> -	struct drm_i915_private *i915 =
> -		container_of(event->pmu, typeof(*i915), pmu.base);
> -	struct i915_pmu *pmu = &i915->pmu;
> +	struct i915_pmu *pmu = event_to_pmu(event);
>
>	if (pmu->closed)
>		goto out;
>
>	if (flags & PERF_EF_UPDATE)
>		i915_pmu_event_read(event);
> +
>	i915_pmu_disable(event);
>
>  out:
> --
> 2.43.0
>