Re: [PATCH net v2 0/2] tcp: restrict crossed SYN specific actions to SYN-ACK

From: Paolo Abeni
Date: Tue Jul 23 2024 - 04:10:35 EST


On 7/18/24 12:33, Matthieu Baerts (NGI0) wrote:
A recent commit in TCP affects TFO and MPTCP in some cases. The first
patch fixes that.

The second one applies the same fix to another crossed SYN specific
action just before.

These two fixes simply restrict what should be done only for crossed SYN
cases to packets with SYN-ACK flags.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
---
Changes in v2:
- Patch 1/2 has a simpler and generic check (Kuniyuki), and an updated
comment.
- New patch 2/2: a related fix
- Link to v1: https://lore.kernel.org/r/20240716-upstream-net-next-20240716-tcp-3rd-ack-consume-sk_socket-v1-1-4e61d0b79233@xxxxxxxxxx

Re-adding Neal for awareness. It would be great if this could go through some packetdrill testing,

Thanks!

Paolo