Re: [PATCH v2 2/3] memory tiering: introduce folio_has_cpupid() check

[Zi Yan]

On Tue Jul 23, 2024 at 6:14 AM EDT, David Hildenbrand wrote:
> > 
> > The static version of folio_has_cpupid() is defined in include/linux/mm.h
> > if !CONFIG_NUMA_BALANCING but you define the function in memory-tiers.c
> > unconditionally, a file that is compiled predicated on CONFIG_NUMA.
> > 
> > So a config with !CONFIG_NUMA_BALANCING but CONFIG_NUMA set results in a
> > compilation error (I just hit it this morning in mm-unstable).
> > 
> > A minimal fix for this is to wrap the declaration in:
> > 
> > #ifdef CONFIG_NUMA_BALANCING
> > ...
> > #endif
> > 
> > I've tried this locally and it resolves the issue.

Will fix it. Thanks.

>
> Agreed, with that
>
> Acked-by: David Hildenbrand <david@xxxxxxxxxx>

Thanks.


-- 
Best Regards,
Yan, Zi

Attachment: signature.asc
Description: PGP signature