Re: [PATCH v1 2/2] perf script: Fix for `perf script +F metric` with leader sampling

From: Andi Kleen
Date: Tue Jul 23 2024 - 11:40:09 EST


> Yeah I suppose it's strictly better now without the segfault. Could you pull
> in the test and update it to add -a? At least then that behavior will be
> locked down and we can extend it later without -a.

Ian's patch really implements completely new functionality (supporting
metrics over multiple groups). It isn't a regression fix, but completely
redesigns the old "single group" feature.

> I also tested Andi's V5 and still got the segfault.

Yes the earlier versions worked, but they broke perf stat report.
I think the right short term fix is to use V3 or so, but with a
check that perf stat report isn't used.

Then perhaps the new functionality of multiple groups can be considered
over it.

-Andi