Re: [PATH v5 0/3] vdpa: support set mac address from vdpa tool

From: Cindy Lu
Date: Tue Jul 23 2024 - 22:19:14 EST


On Wed, 24 Jul 2024 at 02:45, Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Tue, Jul 23, 2024 at 01:39:19PM +0800, Cindy Lu wrote:
> > Add support for setting the MAC address using the VDPA tool.
> > This feature will allow setting the MAC address using the VDPA tool.
> > For example, in vdpa_sim_net, the implementation sets the MAC address
> > to the config space. However, for other drivers, they can implement their
> > own function, not limited to the config space.
> >
> > Changelog v2
> > - Changed the function name to prevent misunderstanding
> > - Added check for blk device
> > - Addressed the comments
> > Changelog v3
> > - Split the function of the net device from vdpa_nl_cmd_dev_attr_set_doit
> > - Add a lock for the network device's dev_set_attr operation
> > - Address the comments
> > Changelog v4
> > - Address the comments
> > - Add a lock for the vdap_sim?_net device's dev_set_attr operation
> > Changelog v5
> > - Address the comments
>
> This history is to help reviewers of previous versions know if there
> comments have been addressed. Just saying 'Address the comments' is
> not useful. Please give a one line summary of each of the comment
> which has been addressed, maybe including how it was addressed.
>
> Andrew
>
will change this
Thanks
cindy