Re: [PATCH v4 2/5] dt-bindings: usb: qcom,dwc3: Update ipq5332 clock details

[Krzysztof Kozlowski]

On 23/07/2024 11:03, Varadarajan Narayanan wrote:
> USB uses icc-clk framework to enable the NoC interface clock.
> Hence the 'iface' clock is removed from the list of clocks.
> Update the clock-names list accordingly.

But the clock is still there and is still used by this block. This looks
like adjusting hardware per Linux implementation.

Why suddenly this clock was removed from this hardware?

> 
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/usb/qcom,dwc3.yaml      | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index efde47a5b145..6c5f962bbcf9 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -220,6 +220,22 @@ allOf:
>              - const: sleep
>              - const: mock_utmi
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,ipq5332-dwc3
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 3
> +        clock-names:
> +          items:
> +            - const: core
> +            - const: sleep
> +            - const: mock_utmi

So this is the same as first case. Just put it there. It's your task to
check if you are duplicating a case, not reviewer's...

Best regards,
Krzysztof