Re: [PATCH] arm64/mm: Drop PMD_SECT_VALID

From: Ryan Roberts
Date: Wed Jul 24 2024 - 03:52:49 EST


On 24/07/2024 05:47, Anshuman Khandual wrote:
> This just drops off the macro PMD_SECT_VALID which remains unused. Because
> macro PMD_TYPE_SECT with same value (_AT(pmdval_t, 1) << 0), gets used for
> creating or updating given block mappings.
>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Ryan Roberts <ryan.roberts@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

Reviewed-by: Ryan Roberts <ryan.roberts@xxxxxxx>

> ---
> arch/arm64/include/asm/pgtable-hwdef.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
> index 1f60aa1bc750..86e803ea8885 100644
> --- a/arch/arm64/include/asm/pgtable-hwdef.h
> +++ b/arch/arm64/include/asm/pgtable-hwdef.h
> @@ -135,7 +135,6 @@
> /*
> * Section
> */
> -#define PMD_SECT_VALID (_AT(pmdval_t, 1) << 0)
> #define PMD_SECT_USER (_AT(pmdval_t, 1) << 6) /* AP[1] */
> #define PMD_SECT_RDONLY (_AT(pmdval_t, 1) << 7) /* AP[2] */
> #define PMD_SECT_S (_AT(pmdval_t, 3) << 8)