Re: [PATCH v4 2/2] drm/panel: boe-th101mb31ig002 : using drm_connector_helper_get_modes_fixed()

From: neil . armstrong
Date: Wed Jul 24 2024 - 03:59:05 EST


Hi Doug,

On 23/07/2024 21:48, Doug Anderson wrote:
Hi,

On Mon, Jul 22, 2024 at 11:26 PM Zhaoxiong Lv
<lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

Use public functions( drm_connector_helper_get_modes_fixed()) to
get porch parameters.

Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
---
Changes between V4 and V3:
- 1.Modify the return value, return drm_connector_helper_get_modes_fixed(connector, desc_mode).
v3: https://lore.kernel.org/all/20240722092428.24499-3-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

Changes between V3 and V2:
- 1. Keep bpc settings and drm_connector_set_panel_orientation() function..
v2: https://lore.kernel.org/all/20240716121112.14435-3-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
---
.../drm/panel/panel-boe-th101mb31ig002-28a.c | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

I'd assume that Neil or Jessica will apply these two patches assuming
they agree it looks OK. If this is stagnant for a while then I'll
apply it.

Thanks for the review, I'm still working this week so I'll apply this serie,
but I'll be off for the next 3 weeks so feel free to apply reviewed panel patches
while I'm away (I'll still be pingable on irc if needed!)

Thanks,
Neil


-Doug