Re: [PATCH v2 2/2] ARM: dts: aspeed: catalina: add Meta Catalina BMC

[Krzysztof Kozlowski]

On 24/07/2024 09:41, Potin Lai wrote:
> Add linux device tree entry for Meta(Facebook) Catalina compute-tray
> BMC using AT2600 SoC.
> 
> Signed-off-by: Potin Lai <potin.lai@xxxxxxxxxxxx>

Thank you for your patch. There is something to discuss/improve.

> +		i2c1mux0ch4: i2c@4 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x4>;
> +
> +			power-monitor@42 {
> +				compatible = "lltc,ltc4287";
> +				reg = <0x42>;
> +				shunt-resistor-micro-ohms = <200>;
> +			};
> +			power-monitor@43 {
> +				compatible = "lltc,ltc4287";
> +				reg = <0x43>;
> +				shunt-resistor-micro-ohms = <200>;
> +			};
> +		};
> +		i2c1mux0ch5: i2c@5 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x5>;
> +
> +			// PDB FRU EEPROM
> +			eeprom@54 {
> +				compatible = "atmel,24c64";
> +				reg = <0x54>;
> +			};
> +
> +			// PDB TEMP SENSOR
> +			tmp75@4f {

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation



Best regards,
Krzysztof