Re: [PATCH][next] drm/i915/dp: Make read-only array bw_gbps static const

From: Jani Nikula
Date: Wed Jul 24 2024 - 06:06:16 EST


On Mon, 22 Jul 2024, Colin Ian King <colin.i.king@xxxxxxxxx> wrote:
> Don't populate the read-only array bw_gbps on the stack at run time,
> instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Pushed to drm-intel-next, thanks for the patch.

BR,
Jani.

> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 59f11af3b0a1..a082ed8f5464 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3434,7 +3434,7 @@ static void intel_dp_get_pcon_dsc_cap(struct intel_dp *intel_dp)
>
> static int intel_dp_pcon_get_frl_mask(u8 frl_bw_mask)
> {
> - int bw_gbps[] = {9, 18, 24, 32, 40, 48};
> + static const int bw_gbps[] = {9, 18, 24, 32, 40, 48};
> int i;
>
> for (i = ARRAY_SIZE(bw_gbps) - 1; i >= 0; i--) {

--
Jani Nikula, Intel