Re: [regression] ENOTTY returned for tty fds

[Herbert Xu]

On Wed, Jul 24, 2024 at 12:15:39PM +0200, Greg KH wrote:
>
> -ENOTTY is the documented result of invalid ioctl arguments sent, I am
> pretty sure POSIX requires this somewhere.  So this was fixing a
> requirement here...

POSIX does not specify this at all:

https://pubs.opengroup.org/onlinepubs/9699919799/functions/ioctl.html

I think this should be reverted as it breaks user-space code
that dates back to 2003.

ENOTTY doesn't even make sense anyway as it literally means "is not a
terminal" and pseudo-ttys certainly are terminals.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt